[#1722] avoid NPE in TupleTransformatorFactory #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reason a classMappingIndex sometimes points to a non-present field in the tuple (filtered via fetches mechanism). The correct fix should be somewhere else but that this is probably good enough - just don't perfomr any tuple transformation for non-present fields. Also, fix a small bug in hasSubFetches. The wrongly implemented equality check lead to overfetching.
|
Can you please add a test case that reproducers this issue? I'd like to make sure we don't reintroduce such a regression again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason a classMappingIndex sometimes
points to a non-present field in the tuple (filtered
via fetches mechanism). The correct fix should be somewhere
else but that this is probably good enough - just don't
perfomr any tuple transformation for non-present fields.
Also, fix a small bug in hasSubFetches. The wrongly
implemented equality check lead to overfetching.
Description
Related Issue
Motivation and Context