feat: Add support for timeframes.txt #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+19
to
+27
| it('should return empty array if no timeframes', () => { | ||
| const timeframeGroupId = 'not_real'; | ||
|
|
||
| const results = getTimeframes({ | ||
| timeframe_group_id: timeframeGroupId, | ||
| }); | ||
| should.exists(results); | ||
| results.should.have.length(0); | ||
| }); |
There was a problem hiding this comment.
It looks like the included test dataset does not include timeframes.txt, so I was not able to write a test that confirms the actual database output of getTimeframes.
|
Excellent! Thanks for letting me know about this new GTFS file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WMATA here in DC started including the optional
timeframes.txtto their GTFS datasets. Currently,node-gtfsdoesn't importtimeframes.txtinto SQLite.timeframes.txtappears to be part of the standard GTFS Schedule dataset.WMATA Rail GTFS Static details: https://developer.wmata.com/docs/services/gtfs/operations/5cdc5367acb52c9350f69753
Dataset with
timeframes.txtincluded: wmata-gtfs-rail-static.zipNote: When using VSCode, I had a bit of trouble getting linting and formatting to work. Apologies if there are any formatting mistakes here. It looks like the
npm run lintcommand from the README doesn't work.