Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot exclude type yml from file list #205

Closed
kehoecj opened this issue Oct 28, 2024 · 5 comments · Fixed by #206
Closed

Cannot exclude type yml from file list #205

kehoecj opened this issue Oct 28, 2024 · 5 comments · Fixed by #206
Labels
bug Something isn't working

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Oct 28, 2024

validator --exclude-file-types=yml raises throws an error that it's an invalid file type
@kehoecj kehoecj added the bug Something isn't working label Oct 28, 2024
@gurukiran07
Copy link
Contributor

I can work on this.

@gurukiran07 gurukiran07 mentioned this issue Oct 28, 2024
Merged
@gurukiran07
Copy link
Contributor

PR: #206

@gurukiran07
Copy link
Contributor

validator --exclude-file-types=YAML also fails. The current search is case-sensitive. Do we want to make it case-insensitive?

@kehoecj

@kehoecj
Copy link
Collaborator Author

kehoecj commented Oct 28, 2024

validator --exclude-file-types=YAML also fails. The current search is case-sensitive. Do we want to make it case-insensitive?

@kehoecj

@gurukiran07 Case insensitive would be nice if you can

@ccoVeille ccoVeille mentioned this issue Oct 29, 2024
Open
@gurukiran07
Copy link
Contributor

validator --exclude-file-types=YAML also fails. The current search is case-sensitive. Do we want to make it case-insensitive?
@kehoecj

@gurukiran07 Case insensitive would be nice if you can

Made the search case insensitive. PR #206
@kehoecj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: yml is valid type gurukiran07/config-file-validator
2 participants
@gurukiran07 @kehoecj