Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: yml is valid type #206

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Fix: yml is valid type #206

merged 4 commits into from
Oct 30, 2024

Conversation

gurukiran07
Copy link
Contributor

Closes #205

Make searching for extensions considering all the possible extensions from FileType.Extensions instead of FileType.Name

Testing:
image

@gurukiran07 gurukiran07 mentioned this pull request Oct 28, 2024
Closed
@gurukiran07 gurukiran07 requested a review from ccoVeille October 30, 2024 04:34
@mohizzzol
Copy link

merge it...

kehoecj
kehoecj approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @gurukiran07

@kehoecj kehoecj merged commit ae1ed65 into Boeing:main Oct 30, 2024
10 checks passed
@gurukiran07 gurukiran07 deleted the invalid-type-fix branch October 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohizzzol mohizzzol mohizzzol approved these changes

@kehoecj kehoecj kehoecj approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot exclude type yml from file list
4 participants
@gurukiran07 @mohizzzol @ccoVeille @kehoecj