Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc/nats jetstream #100

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Poc/nats jetstream #100

wants to merge 30 commits into from

Conversation

NiklasArbin
Copy link
Member

support jetstream

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary by GPT-4

The changes in this commit include:

  • Added new files for JetStream support in the KnightBus library. This includes new interfaces and classes for handling JetStream messages, configuration, and bus operations.
  • Modified the existing NatsBus class to support JetStream operations.
  • Updated the Docker commands in the GitHub workflows file to start a NATS server with JetStream enabled.
  • Added new test cases for testing JetStream functionality.
  • Created a new example project to demonstrate usage of the JetStream features.

Suggestions

The changes in this PR are well structured and clear. The addition of new files and changes to existing ones are logically organized. However, there are a few suggestions for improvement:

  1. In the JetStreamBus.cs file, consider adding comments to explain the purpose of each method and what they do. This will improve code readability and maintainability.

  2. In the KnightBus.sln file, it would be helpful to add comments explaining what each project reference is for.

  3. In the KnightBus.sln.DotSettings file, consider adding a newline at the end of the file to adhere to POSIX standards.

  4. In the NatsChannelReceiverBase.cs file, consider handling exceptions in a more granular way rather than catching all exceptions in a single catch block.

  5. In the NatsConfiguration.cs file, consider using auto-properties for brevity.

  6. In the NatsExtensions.cs file, consider adding XML comments for public methods to provide IntelliSense support and improve code readability.

  7. In various test files (e.g., CommandTests.cs, EventTests.cs, etc.), ensure that all test cases have meaningful names that clearly describe what they're testing.

  8. Consider adding unit tests for new classes and methods introduced in this PR to ensure they work as expected under different scenarios.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants