Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-16]: MM-61578:Ensure all interactive functionality is operable with the keyboard #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-16]: MM-61578:Ensure all interactive functionality is operable with the keyboard #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...nents/add_groups_to_channel_modal/__snapshots__/add_groups_to_channel_modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,14 @@ exports[`components/AddGroupsToChannelModal should match when renderOption is ca
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add groups to channel"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
Expand Down Expand Up @@ -206,13 +207,14 @@ exports[`components/AddGroupsToChannelModal should match when renderOption is ca
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add groups to channel"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
Expand Down Expand Up @@ -255,13 +257,14 @@ exports[`components/AddGroupsToChannelModal should match when renderOption is ca
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add groups to channel"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
7 changes: 5 additions & 2 deletions webapp/channels/src/components/add_groups_to_channel_modal/add_groups_to_channel_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,12 @@ export class AddGroupsToChannelModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Add groups to channel'
>
<i className='icon icon-plus'/>
</div>
</button>
</div>
</div>
);
Expand Down
10 changes: 6 additions & 4 deletions .../components/add_groups_to_team_modal/__snapshots__/add_groups_to_team_modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,14 @@ exports[`components/AddGroupsToTeamModal should match when renderOption is calle
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add groups to team"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
Expand Down Expand Up @@ -247,13 +248,14 @@ exports[`components/AddGroupsToTeamModal should match when renderOption is calle
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add groups to team"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
7 changes: 5 additions & 2 deletions webapp/channels/src/components/add_groups_to_team_modal/add_groups_to_team_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,12 @@ export class AddGroupsToTeamModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Add groups to team'
>
<i className='icon icon-plus'/>
</div>
</button>
</div>
</div>
);
Expand Down
7 changes: 5 additions & 2 deletions ...ls/src/components/add_user_to_group_multiselect/multiselect_option/multiselect_option.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,14 @@ const MultiSelectOption = React.forwardRef(({
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label={`Select Option ${option.label}`}
>
<i
className='icon icon-plus'
/>
</div>
</button>
</div>
</div>
);
Expand Down
7 changes: 5 additions & 2 deletions webapp/channels/src/components/add_users_to_team_modal/add_users_to_team_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,14 @@ export class AddUsersToTeamModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Add users to team'
>
<i
className='icon icon-plus'
/>
</div>
</button>
</div>
</div>
);
Expand Down
7 changes: 5 additions & 2 deletions ...dmin_console/system_roles/system_role/add_users_to_role_modal/add_users_to_role_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,14 @@ export class AddUsersToRoleModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Add users to role'
>
<i
className='icon icon-plus'
/>
</div>
</button>
</div>
</div>
);
Expand Down
17 changes: 8 additions & 9 deletions webapp/channels/src/components/channel_invite_modal/channel_invite_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,13 +408,9 @@ export class ChannelInviteModal extends React.PureComponent<Props, State> {
{displayName}
{option.is_bot && <BotTag/>}
{isGuest(option.roles) && <GuestTag className='popoverlist'/>}
{displayName === option.username ?
null :
<UsernameSpan
className='ml-2 light'
>
{'@'}{option.username}
</UsernameSpan>
{displayName === option.username ? null : <UsernameSpan className='ml-2 light'>
{'@'}{option.username}
</UsernameSpan>
}
<UserMappingSpan
className='light'
Expand All @@ -425,11 +421,14 @@ export class ChannelInviteModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Add channel to invite'
>
<i
className='icon icon-plus'
/>
</div>
</button>
</div>
</div>
);
Expand Down
7 changes: 5 additions & 2 deletions webapp/channels/src/components/channel_selector_modal/channel_selector_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,12 @@ export class ChannelSelectorModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label='Select channel'
>
<i className='icon icon-plus'/>
</div>
</button>
</div>
</div>
);
Expand Down
10 changes: 6 additions & 4 deletions ...nnels/src/components/more_direct_channels/list_item/__snapshots__/list_item.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,14 @@ exports[`ListItem should match snapshot when rendering GroupChannel 1`] = `
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add option undefined"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
Expand All @@ -62,13 +63,14 @@ exports[`ListItem should match snapshot when rendering user 1`] = `
<div
className="more-modal__actions"
>
<div
<button
aria-label="Add option undefined"
className="more-modal__actions--round"
>
<i
className="icon icon-plus"
/>
</div>
</button>
</div>
</div>
`;
7 changes: 5 additions & 2 deletions webapp/channels/src/components/more_direct_channels/list_item/list_item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,12 @@ const ListItem = React.forwardRef((props: Props, ref?: React.Ref<HTMLDivElement>
}

<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label={`Add option ${option.label}`}
>
<i className='icon icon-plus'/>
</div>
</button>
</div>
</div>
);
Expand Down
7 changes: 5 additions & 2 deletions webapp/channels/src/components/team_selector_modal/team_selector_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,12 @@ export class TeamSelectorModal extends React.PureComponent<Props, State> {
</div>
</div>
<div className='more-modal__actions'>
<div className='more-modal__actions--round'>
<button
className='more-modal__actions--round'
aria-label={`Select team ${option.label}`}
>
<i className='fa fa-plus'/>
</div>
</button>
</div>
</div>
);
Expand Down
5 changes: 3 additions & 2 deletions webapp/channels/src/sass/components/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,9 +933,10 @@
display: none;
width: 32px;
height: 32px;
line-height: 32px;
padding: 0;
border: none;
opacity: 0.75;
text-align: center;
text-align: center
}

.more-modal__right {
Expand Down
Loading