Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-23]: Updated the aria-label property of sidebar expand icon #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-23]: Updated the aria-label property of sidebar expand icon #20

wants to merge 1 commit into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Dec 13, 2024 •
edited
Loading

Summary

  • Added aria-label to the expand and collapse icon

Steps to reproduce

  • Locate the "Expand Sidebar Icon/ Collapse Sidebar Icon" button.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".

Expected Behavior

  • Expanded/Collapse icon must have an accessible name so that assistive technology can announce it.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61620

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884