[MA-25]: MM-61597: Ensure custom buttons provide proper name, role, and state information in move to option #21
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhSharma-884
force-pushed
the
ma_25/issue_mm_61597
branch
from
35e22bb to
9ce89e4
Compare
SaurabhSharma-884
force-pushed
the
ma_25/issue_mm_61597
branch
from
9ce89e4 to
e5564b8
Compare
SaurabhSharma-884
requested review from
ayush-chauhan233
and removed request for
thisisankur0
| @@ -11,7 +11,7 @@ exports[`GenericModal should match snapshot for base case 1`] = ` | |||
| aria-hidden="true" | |||
| /> | |||
| <div | |||
| role="dialog" | |||
| role="none" | |||
There was a problem hiding this comment.
Why did this snap change to none?
ayush-chauhan233
approved these changes
Dec 19, 2024
SaurabhSharma-884
added
the
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures custom buttons provide proper name, role, and state information in the move to option of channel header drop-down.
There are buttons without appropriate role information. Examples include:
-Move to, Favorites, Channels and New Category buttons
Steps to reproduce
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-61597
Screenshots
Release Note