Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-28]: MM-61603: Ensure custom controls provide proper name, role, and state information #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaurabhSharma-884
Copy link

Summary

This PR adds provides proper name, role, and state information to custom controls in message post priority dialog-Standard, Important and Urgent buttons

Steps to reproduce

  • Navigate to the Message priority button and select it.
  • Now navigate to the Standard button.
  • Notice that the state of the element is not programatically implemented.

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-61603

Screenshots

image (1)
image

Release Note


Copy link

⚠️ One or more flaky tests detected ⚠️

TestRetries
Postgres with binary parameters (Results)
com/mattermost/mattermost/server/v8/channels/api4.TestGetOAuthApp1

Copy link

⚠️ One or more flaky tests detected ⚠️

  • Failing job: github.com/mattermost/mattermost:MySQL
  • Double check your code to ensure you haven't introduced a flaky test.
  • If this seems to be unrelated to your changes, submit a separate pull request to skip the flaky tests (e.g. 23360) and file JIRA ticket (e.g. MM-52743) for later investigation.
TestRetries
MySQL (Results)
com/mattermost/mattermost/server/v8/channels/api4.TestPublishUserTyping/should_send_typing_event_via_websocket_when_triggering_a_typing_event_for_a_user_with_a_common_channel1
com/mattermost/mattermost/server/v8/channels/api4.TestPublishUserTyping1

@ayush-chauhan233 ayush-chauhan233 added the Approved Dev approved, ready to be reviewed by MM team label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Dev approved, ready to be reviewed by MM team On External
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants