Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple tabswitcher bugs (workspace-based rendering, focus, oversizing) #518

Merged
merged 3 commits into from
Jan 31, 2024
Merged

fix: multiple tabswitcher bugs (workspace-based rendering, focus, oversizing) #518

merged 3 commits into from
Jan 31, 2024

Conversation

JoshStrobl
Copy link
Member

  1. Fixed workspace-based rendering by adding missing invalidate filter during construction.
  2. Fix focus issue caused by our get_time providing an incorrect event timing. Resolved by using Gdk.X11.get_server_time, need to rip that out when we switch to Wayland.
  3. Fix TabSwitcher sizing not updating

Fixes:

@JoshStrobl
fix: multiple tabswitcher bugs (workspace-based rendering, focus, ove…
768146c 
…rsizing)

1. Fixed workspace-based rendering by adding missing invalidate filter during construction.
2. Fix focus issue caused by our get_time providing an incorrect event timing. Resolved by using Gdk.X11.get_server_time, need to rip that out when we switch to Wayland.
3. Fix TabSwitcher sizing not updating

Fixes:

- #515
- #517
@JoshStrobl JoshStrobl added this to the 10.9.1 milestone Jan 30, 2024
@JoshStrobl JoshStrobl requested a review from a team January 30, 2024 22:26
@JoshStrobl JoshStrobl self-assigned this Jan 30, 2024
@JoshStrobl JoshStrobl linked an issue Jan 30, 2024 that may be closed by this pull request
[Bug] Tab Switcher doesn't work when "Show all windows" is off #517
Closed
EbonJaeger
EbonJaeger requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After compiling this, I can no longer get any weirdness to happen with the tab switcher :D

src/daemon/tabswitcher.vala Outdated Show resolved Hide resolved
EbonJaeger
EbonJaeger approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and appears to be working well for me. I'm not seeing any more weird behavior with the tab switcher.

@JoshStrobl
Copy link
Member Author

@serebit I believe this is something you wanted to test too?

@serebit
Copy link
Member

serebit commented Jan 31, 2024

Yes, I've installed it and will be testing it later today.

EbonJaeger
EbonJaeger approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me, though I do only use 100% scaling.

@serebit
Copy link
Member

serebit commented Jan 31, 2024

Did not investigate workspace applet changes, but both tab switching issues have been fixed to my satisfaction. Approved.

@JoshStrobl JoshStrobl merged commit 00ed13f into main Jan 31, 2024
1 check failed
@JoshStrobl JoshStrobl deleted the 517-bug-tab-switcher-doesnt-work-when-show-all-windows-is-off branch January 31, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serebit serebit serebit approved these changes

@EbonJaeger EbonJaeger EbonJaeger approved these changes

Assignees

@JoshStrobl JoshStrobl

Labels
None yet
Projects
Budgie 10
Status: Done
Milestone
10.9.1
Development

Successfully merging this pull request may close these issues.

[Bug] Tab Switcher doesn't work when "Show all windows" is off
3 participants
@JoshStrobl @serebit @EbonJaeger