Add missing dependency to 'trash' applet meson.build #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
link_libpanelenum is not currently listed in applet_trash_deps. Although this builds just fine on systems using meson with ninja, this will result in build failure on systems that use meson with samurai, outputting the following error message:
This error can be especially problematic on distros like Alpine Linux which only ship samurai in the main repositories. Apparently, this is due to a difference in how ninja and samurai schedule build edges (see Meson Issue #9937 & samurai differences from ninja), which consequently requires dependencies to be specified more explicitly.
Therefore, this pull requests adds link_libpanelenum into applet_trash_deps, to ensure that Budgie can be built and compiled on any system.
Also, somewhat related to the pull request, I noticed that link_libpanelenum is not actually linked to libpanelenum. I refrained from modifying this in case there was a functional reason for it, but I'd happily create another pull request for it if there's none.
Submitter Checklist
git rebase -i
(if needed)