Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session management #638

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Session management #638

wants to merge 6 commits into from

Conversation

fossfreedom
Copy link
Contributor

@fossfreedom fossfreedom commented Nov 17, 2024

Description

This PR rejigs session management in budgie;

  1. the xsession desktop file is now installed in wayland-session; this is the default launching magpie-wm v1
  2. Also added in a session for labwc - note this expects labwc as a runtime and we should assume distros are using labwc v0.8.1 or later using wlroots 0.18.x
  3. The previous budgie-wm shim has been moved to our power exe. This allows the popup confirmation to be displayed. Note this confirmation dialog needs budgie-session
  4. We no longer builds budgie-wm - the gnome-session/sessions file no longer autostarts budgie-wm

Note - this all requires the screenlock branch since the previous budgie-screensaver/gnome-screensaver stuff broke session management.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@JoshStrobl
Copy link
Member

If we are no longer building wm, any reason for us to not just nuke it?

@fossfreedom
Copy link
Contributor Author

If we are no longer building wm, any reason for us to not just nuke it?

There are still bits of capability we have to mull-over - such as OSD support, Alt+Tab comes to mind. Its easier to have these still in the code base to refer to, grep through etc. Can nuke it a little later as part of a general cleanup including tidying up manuals and other stuff.

@fossfreedom
Copy link
Contributor Author

Ah... the wm schema keys also need special treatment. Will tidy this

@JoshStrobl JoshStrobl self-requested a review November 21, 2024 18:35
Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but all the screenlock bits need to be decoupled from this PR as it is part of another.

@fossfreedom
Copy link
Contributor Author

Rebased on main with a revert of the screenlock commit.

Everything seems to work with the obvious exception of the lock option on the powerdialog - that is the separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants