Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 ft single course dashboard uiux design #123

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

drfidel
Copy link
Contributor

@drfidel drfidel commented Jul 14, 2023

Description

Once logged in, a teacher could view list of courses in a table which is boring visually, also after selecting a course to view, modules were not active once user selected resume course.

course Cards are used to present list of logged in users enrolled courses and also a list of all courses offered presented on the teachers page.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 122)

How Has This Been Tested?

DOM testing

Screenshots (if applicable, else remove this line / section)

course-cards
course-cards222

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

@drfidel drfidel requested a review from mariamiah July 14, 2023 09:14
@drfidel drfidel self-assigned this Jul 14, 2023
@drfidel drfidel linked an issue Jul 14, 2023 that may be closed by this pull request
@mariamiah
Copy link
Collaborator

mariamiah commented Jul 25, 2023

Is this still in progress or ready for review?

@drfidel drfidel marked this pull request as ready for review July 26, 2023 07:42
@drfidel
Copy link
Contributor Author

drfidel commented Jul 26, 2023

Is this still in progress or ready for review,
Yes it is ready for review...

@drfidel
Copy link
Contributor Author

drfidel commented Jul 26, 2023

You may review the code

@drfidel
Copy link
Contributor Author

drfidel commented Aug 3, 2023

@mariamiah Tried passing props from the singlecourse container, but had issues with type-errors.... while attempting to use the values to populate course cards, thus decided to use hooks to fetch...

"classnames": "^2.2.6",
"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.2",
"enzyme-to-json": "^3.5.0",
"eslint-config-airbnb": "^18.1.0",
"express": "^4.17.1",
"formik": "^2.1.4",
"jquery": "^3.7.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question though What are we using jquery for?

Copy link
Contributor Author

@drfidel drfidel Aug 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because the nav bar component on the teacher's page that i was testing wasnt working....but i think it was my dev environments issue....let me clean those sections out, thanks

Copy link
Collaborator

@mariamiah mariamiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far 💯 , a few changes to look at though

src/index.js Outdated Show resolved Hide resolved
src/components/CoursesTable/CoursesTable.jsx Outdated Show resolved Hide resolved
@drfidel drfidel requested a review from mariamiah August 11, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Single Course Dashboard UI/UX Design
2 participants