Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft membership api setup #31

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

johnakon
Copy link
Collaborator

@johnakon johnakon commented May 11, 2020

Description

Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.

Screenshots (if applicable, else remove this line / section)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

asiimwearnold and others added 2 commits May 8, 2020 00:10
This feature will control the authentication and authorisation for the application.\n

Fixes BuildForSDG#6
@amkayondo amkayondo self-requested a review May 11, 2020 09:52
Copy link
Member

@amkayondo amkayondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify your code to the ES6 standard
Learn more about how to use;

  • babel
  • .env

src/services/membership_api/routes/memberRoute.js Outdated Show resolved Hide resolved
src/services/membership_api/routes/memberRoute.js Outdated Show resolved Hide resolved
src/services/membership_api/index.js Outdated Show resolved Hide resolved
src/services/membership_api/index.js Outdated Show resolved Hide resolved
@johnakon
Copy link
Collaborator Author

changes made

@johnakon
Copy link
Collaborator Author

changes done

@johnakon johnakon closed this May 27, 2020
@johnakon johnakon reopened this May 27, 2020
@johnakon johnakon linked an issue May 27, 2020 that may be closed by this pull request
@LadPaule LadPaule self-requested a review June 9, 2020 05:47
parserOptions: {
ecmaVersion: 2018
},
rules: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove rules


const app = express();

app.use(helloMembers);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Setup the Membership API service
4 participants