Fix/comments with quotes

[SamiKamal]

Description

Add a short description of:

• Passed { comments: false } to parseCode,
• The reason was that, adding quotes in a comment would break the parser, for more context check React generator fails when there is a comment with a single quote #613 and Comments cause crash #250 (the latter is a broader issue, this fix is focused on the former issue)

Side effects:

This change means that comments will always get removed

Note:
I've also updated an argument name from x to node to make it more readable.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mitosis-fiddle	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 2, 2024 7:40pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1573747. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx build @builder.io/mitosis-fiddle
• nx run-many --skip-nx-cache --target build --parallel 4 --exclude */e2e-alpine,*/e2e-angular,@builder.io/mitosis-fiddle,@builder.io/talk-*,@builder.io/example-apps
• nx build @builder.io/eslint-plugin-mitosis
• nx build @builder.io/mitosis

---

Sent with 💌 from NxCloud.

[samijaber]

This is great! You just need to update test snapshots with your latest test:

cd packages/core && yarn snapupdate

[samijaber]

You also need to lint using yarn fmt:prettier

[SamiKamal]

You also need to lint using yarn fmt:prettier

All done now 👍🏾

[samijaber]

One unwanted side-effect of your solution is that it removes all comments from all blocks. That would be a lot of useful content that we don't want to lose...

I will investigate a better approach.

[SamiKamal]

Opps, I guess I misunderstood this part, I thought it meant removing the comments from the whole code.

Expected behavior

Expect comments to be ignored/stripped before any Mitosis logic runs, and not cause any issues

[samijaber]

Sorry about that. The ideal expected behaviour is that comments never cause issues and that most comments make it to the final output.

[SamiKamal]

No worries, I'll look for another solution