Feature add docker compose for dev #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahsashadi
reviewed
Feb 15, 2023
| }, | ||
| "devDependencies": { | ||
| "@babel/preset-react": "^7.0.0", | ||
| "@osjs/dev-meta": "^1.0.3", | ||
| "babel-eslint": "^10.1.0", | ||
| "eslint": "^7.30.0", | ||
| "eslint-plugin-react": "^7.24.0" | ||
| "eslint-plugin-react": "^7.24.0", | ||
| "webpack": "^4.46.0", |
There was a problem hiding this comment.
We normally don't add webpack and webpack-cli as a devDependency of packages. They are already added in @osjs/dev-meta package
There was a problem hiding this comment.
It should be added. Because this project needs webpack itself and it should not depend on webpack installation based on another project.
Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR, I have used
docker-composeto make it easier to develop the package insideOSJS. It also helps others to see a demo easily by running only one command.