Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove all *.md, add link to criptapp.org #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: remove all *.md, add link to criptapp.org #27

wants to merge 3 commits into from

Conversation

bearmit
Copy link
Contributor

@bearmit bearmit commented Aug 18, 2023 •
edited
Loading

Details:

  • kept an index to mention this site moved to criptapp.org
  • removed any md file that was specific to jekyl

Once the domain criptscripts.org will point to
criptapp.org/resources/scripts/ we'll be able to remote jekyl entirely. \o/.

Before to merge:

  • criptscript.org is redirects to criptapp.org/resources/scripts/

bearmit
bearmit commented Aug 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bearmit bearmit requested a review from nh916 August 18, 2023 21:30
@bearmit
Copy link
Contributor Author

bearmit commented Aug 25, 2023

@nh916 fyi, I just did a push force on the branch. I figured out some *.md file could be kept because they provide useful information while a developer is browsing the source code without having the CMS related pages opened.

What I did:

  • Removed everything 100% related to the website (except logo).
  • Removed from *.md all the content required by the website, and moved them closer to the source when it was judicious.

Let's wait for Wilfred to migrate criptscripts.org to criptapp.org/resources/scripts/ before to merge.

@bearmit bearmit marked this pull request as draft August 25, 2023 20:30
@nh916
Copy link
Contributor

nh916 commented Aug 25, 2023 •
edited
Loading

@bearmit

I just did a push force on the branch

This scares me a bit, but I think everything should still be fine

I figured out some *.md file could be kept because they provide useful information while a developer is browsing the source code without having the CMS related pages opened.

I love it and I agree!

What I did:

  • Removed everything 100% related to the website (except logo).
  • Removed from *.md all the content required by the website, and moved them closer to the source when it was judicious.

Great work! It all sounds good, I can check the PR for the repo before we merge as well to be sure everything is working correctly.

We could also have a release for CRIPTScripts before we change the repo so that we have the old code cleanly in one place before adding this PR.

Let's wait for Wilfred to migrate criptscripts.org to criptapp.org/resources/scripts/ before to merge.

agreed

@bearmit
Copy link
Contributor Author

bearmit commented Sep 7, 2023

@Ardi028 do we have an update from Wilfred about the domain redirection?

@bearmit bearmit requested review from Ardi028 and removed request for nh916 December 21, 2023 21:49
@bearmit
Copy link
Contributor Author

bearmit commented Dec 21, 2023

@Ardi028 this can be merged once Wilfred setup a redirection or criptsccripts.org to criptapp.org/resources/scripts/

@bearmit bearmit marked this pull request as ready for review December 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ardi028 Ardi028 Awaiting requested review from Ardi028

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearmit @nh916