Title: Resolved issue with Beacon leader being null #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aadibajpai Please review my pr |
aadibajpai
reviewed
Feb 15, 2024
| if (group.leader.id !== user.id && !group.members.includes(user)) | ||
| return new Error("User should be a part of the group"); | ||
| return group; | ||
| const group = await Group.findById(id).populate('leader members').populate({ |
There was a problem hiding this comment.
looks good, need to review the rest
There was a problem hiding this comment.
Hi @aadibajpai, I'm actively addressing the issue. Additionally, I'm proposing a new feature that allows leaders to toggle between displaying their name or remaining anonymous on the beacon. So i want to close this pr for now soon i'll complete proposed feature and create a new pr.
aadibajpai
reviewed
Feb 15, 2024
| const userObj = await newUser.save(); | ||
| return userObj; | ||
| }, | ||
|
|
||
| oAuth: async (_parent, { userInput }) => { |
There was a problem hiding this comment.
using this function for google and oAuth signup, userInput will come from frontend through flutter libraries and then some operations are performed.
for oAuth i have created this Closes #373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:#374