-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the schema version to 8 for the output messages #136
Conversation
jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMsgMetadata.java
Outdated
Show resolved
Hide resolved
jpo-ode-core/src/main/java/us/dot/its/jpo/ode/model/OdeMsgMetadata.java
Outdated
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Outdated
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/traveler/TimTransmogrifierTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/coder/stream/LogFileToAsn1CodecPublisherTest.java
Show resolved
Hide resolved
Ignoring all checkstyle comments regarding line length. Completely refactoring the tests is out of scope of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still seeing a few references to schema version 7. These need to be updated as well, right?
OdeBsmDataTest
OdeMapDataTest
OdePsmDataTest
OdeSpatDataTest
OdeSrmDataTest
OdeSsmDataTest
Co-authored-by: Matt Cook <[email protected]>
…V/jpo-ode into Fix/schema-version-update
jpo-ode-core/src/test/java/us/dot/its/jpo/ode/model/OdeSpatDataTest.java
Show resolved
Hide resolved
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and all tests still pass.
jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/udp/map/MapReceiverTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good & the unit tests pass!
PR Details
Description
Incrementing the
schemaVersion
value for the ODE output messages since a new breaking change has been introduced and this will make it clear that data generated from this version of the jpo-ode is not the same as the older version.The output version has also been removed from the application.yaml. This field wasn't used yet but it would be undesirable to suggest that this field should be customizable since this is explicitly paired with the current version of message output. The schema documentation has been updated to reflect where to change this value if it is necessary.
Related Issue
N/A
Motivation and Context
If the schemaVersion doesn't change, it will be confusing and users may believe they are backwards compatible or that the schema hasn't changed.
How Has This Been Tested?
This has been tested locally with UDP sender scripts and the unit tests have been updated.
Types of changes
Checklist:
ODE Contributing Guide