Migrate TimDepositController to use Spring Kafka

[dmccoystephenson]

PR Details

Description

The TimDepositController class has been modified to use the KafkaTemplate class instead of the KafkaConsumer class.

Related Issue

No related GitHub issue.

Motivation and Context

Implementing Spring Kafka gives us better lifecycle management of producers and consumers, more reusable producer/consumer code, easier testability, and a more robust production-ready Kafka library. This is part of a more significant effort to replace our hand-rolled Kafka implementation with Spring Kafka. The previous changesets related to this effort are #118, #116, #123, #129, #131 and #134.

How Has This Been Tested?

• Unit tests have been updated and verified to pass.
• Depositing a TIM through the /tim endpoint has been verified to work as expected and the following topics were produced to: topic.OdeTimBroadcastJson, topic.J2735TimBroadcastJson, topic.OdeTimJson, topic.Asn1EncoderInput

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• I have added any new packages to the sonar-scanner.properties file
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
  ODE Contributing Guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[mcook42]

The code changes look good. Without any tests to confirm the swap to KafkaTemplate from MessageProducer didn't change the values produced I'm not comfortable calling these changes tested. Please add some tests to confirm that we are interacting with Kafka as intended. Some helpful examples to use as a guide are https://github.com/CDOT-CV/jpo-ode/blob/dev/jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/udp/tim/TimReceiverTest.java and https://github.com/CDOT-CV/jpo-ode/blob/dev/jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/kafka/listeners/Asn1DecodedDataRouterTest.java