Data flow diagram updates - Spring Kafka related #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draw.io supports editing the generated .png file directly, so including both files is redundant and can risk drift between the two leading to inaccuracy
Draw.io supports editing the generated .png file directly, so including both files is redundant and can risk drift between the two leading to inaccuracy
Refreshed the diagram to reflect recent changes in the data flow. Ensures documentation remains accurate and aligned with the current system.
mcook42
requested review from
payneBrandon,
dmccoystephenson,
drewjj,
Michael7371,
jacob6838 and
mwodahl
drewjj
approved these changes
Dec 30, 2024
dmccoystephenson
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Some diagrams and their descriptions have discrepancies, and a few pieces of information are missing. I've provided several comments to highlight these points. While some issues were pre-existing and not directly tied to the Spring Kafka migration, addressing them now could improve overall clarity and accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Updates to the data flow diagrams related to the recent Spring Kafka migration work. The files with the
drawioextension were also deleted since Drawio editors can edit the PNG directly. Keeping both around was cumbersome, and the PNG files were more usable anyway (you don't need special editors/tools/parsers to view a PNG).Related Issue
Motivation and Context
These diagram updates weren't performed during the related code changes in #118, #116, #123, #129, #131 and #134.
How Has This Been Tested?
These do not effect the code, so they were not tested.
Types of changes
Checklist:
ODE Contributing Guide