Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J2735 2020 Compatibility #1

Merged
merged 6 commits into from
Dec 27, 2023
Merged

J2735 2020 Compatibility #1

merged 6 commits into from
Dec 27, 2023

Conversation

dmccoystephenson
Copy link
Member

TIM Config

The odevalidator/configs/config_tim.ini file has been updated to conform to J2735 2020. Specifically, the following expected field namess were modified:

  • sspTimRights => notUsed
  • duratonTime => durationTime
  • sspLocationRights => notUsed1

Test Data

The following test data files were modified to conform to J2735 2020:

  • tests/testfiles/bad.json
  • tests/testfiles/good.json
  • tests/testfiles/good_broadcast_tim.json
  • validate_queue_response_full_sample.json

The following outdated fields were replaced in these files:

  • sspTimRights => notUsed
  • duratonTime => durationTime
  • sspLocationRights => notUsed1
  • sspMsgRights1 => notUsed2
  • sspMsgRights2 => notUsed3

Testing

After the modifications to the config & test files were made, the unittest.sh script was verified to have identical output as when run in the master branch.

Issues

In the process of testing, a few issues were uncovered that were not related to the modifications made here:

These issues are also occurring in the master branch.

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Tests run fine minus the ones also failing in master

@dmccoystephenson dmccoystephenson removed the request for review from drewjj December 27, 2023 23:11
@dmccoystephenson dmccoystephenson merged commit 4222a1e into master Dec 27, 2023
@dmccoystephenson dmccoystephenson deleted the j2735/conform-to-2020 branch December 27, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants