Add some tests and run them in CI.

Also fix a bug with demangling libcalls and fix another issue with
trieste's use of snmalloc.

.github/workflows/main.yml

@@ -10,6 +10,7 @@ on:
 jobs:
   build:
     strategy:
+      fail-fast: false
       matrix:
         config:
         - {
@@ -60,3 +61,7 @@ jobs:
       working-directory: ${{github.workspace}}/build
       # Build your program with the given configuration
       run: NINJA_STATUS="%p [%f:%s/%t] %o/s, %es" && ninja
+    - name: Test
+      working-directory: ${{github.workspace}}/build
+      # Build your program with the given configuration
+      run: ctest -j4 --output-on-failure

Tests/CMakeLists.txt

@@ -1,5 +1,5 @@
 message(STATUS "Adding tests")
-file(GLOB TESTS "*.query" CONFIGURE_DEPENDS "*.query")
+file(GLOB TESTS CONFIGURE_DEPENDS "*.query")
 
 message(STATUS "Tests: ${TESTS}")
 

Tests/compartment_check.query

@@ -0,0 +1,3 @@
+# Check that we can demangle a library export correctly.
+--board inputs/sail.json -j inputs/test-suite.json -q 'data.compartment.compartment_call_allow_list("allocator_test", `test_allocator\(\)`, {"test_runner"})'
+

Tests/compartment_check.query.expected

@@ -0,0 +1 @@
+true

Tests/demangle_compartment_call.query

@@ -0,0 +1,4 @@
+# Check that we can demangle a compartment export correctly.
+--board inputs/sail.json -j inputs/test-suite.json -q 'export_entry_demangle("alloc", input.compartments.allocator.exports[6].export_symbol)'
+
+

Tests/demangle_compartment_call.query.expected

@@ -0,0 +1 @@
+"heap_free(SObjStruct*, void*)"

Tests/demangle_libcall.query

@@ -0,0 +1,3 @@
+# Check that we can demangle a library export correctly.
+--board inputs/sail.json -j inputs/test-suite.json -q 'export_entry_demangle("token_library", input.compartments.token_library.exports[0].export_symbol)'
+

Tests/demangle_libcall.query.expected

@@ -0,0 +1 @@
+"token_obj_unseal(SKeyStruct*, SObjStruct*)"

Tests/mmio_check.query

@@ -0,0 +1,3 @@
+# Check that we can demangle a library export correctly.
+--board inputs/sail.json -j inputs/test-suite.json -q 'data.compartment.mmio_allow_list("clint", {"scheduler"})'
+

Tests/mmio_check.query.expected

@@ -0,0 +1 @@
+true

Tests/sum_quotas.query

@@ -0,0 +1,3 @@
+# Check that we can demangle a library export correctly.
+--board inputs/sail.json -j inputs/test-suite.json -q 'sum([ data.rtos.decode_allocator_capability(c).quota | c = input.compartments[_].imports[_] ; data.rtos.is_allocator_capability(c) ])'
+

Tests/sum_quotas.query.expected

@@ -0,0 +1 @@
+1070080

Tests/testexpected.sh

@@ -1,4 +1,4 @@
 #!/bin/sh
 set -e
-cd $(dirname $(realpath $0))
+cd "$(dirname $(readlink -f -- "$0"))"
 /bin/sh -c "$1 $(grep -v '^#' $2)" | diff - $2.expected

audit.cc

@@ -101,23 +101,34 @@ namespace
 		}
 		auto string                         = get_string(exportName);
 		auto compartmentNameString          = get_string(compartmentName);
+		const std::string_view LibraryExportPrefix = "__library_export_libcalls";
 		const std::string_view ExportPrefix = "__export_";
-		if (!string.starts_with(ExportPrefix))
+		if (string.starts_with(LibraryExportPrefix))
 		{
-			return scalar(false);
+			string = string.substr(LibraryExportPrefix.size());
 		}
-		string = string.substr(ExportPrefix.size());
-		if (!string.starts_with(compartmentNameString))
+		else
 		{
-			return scalar(false);
+			if (!string.starts_with(ExportPrefix))
+			{
+				return scalar(false);
+			}
+			string = string.substr(ExportPrefix.size());
+			if (!string.starts_with(compartmentNameString))
+			{
+				return scalar(false);
+			}
+			string = string.substr(compartmentNameString.size());
 		}
-		string = string.substr(compartmentNameString.size());
 		if (!string.starts_with("_"))
 		{
 			return scalar(false);
 		}
 		string            = string.substr(1);
-		size_t bufferSize = 128;
+		// The way that rego-cpp exposes snmalloc can cause the realloc here to
+		// crash.  Try to allocate a buffer that's large enough that we don't
+		// care.
+		size_t bufferSize = strlen(string.c_str()) * 8;
 		char  *buffer     = static_cast<char *>(malloc(bufferSize));
 		int    error;
 		buffer =