Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the rego-cpp source location. #4

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

davidchisnall
Copy link
Contributor

This makes it easy for rego-cpp to use us for integration testing.

Copy link
Contributor

@matajoh matajoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that you use the C++ API the name here could be something different, REGOCPP_REPO and REGOCPP_TAG for example, but as long as there are options we can set them in CI and all is well.

@davidchisnall
Copy link
Contributor Author

You used these names in your C++ examples too, so I assumed that you had something generic setting them. Happy to use better names if it doesn't make more work for you.

This makes it easy for rego-cpp to use us for integration testing.
@davidchisnall davidchisnall merged commit a0b66c8 into main Jun 6, 2024
6 checks passed
@davidchisnall davidchisnall deleted the override-rego-cpp branch June 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants