Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests to reflect the new output format #6

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

matajoh
Copy link
Contributor

@matajoh matajoh commented Jun 13, 2024

As part of the upgrade of rego-cpp to Rego v0.65.0 the output of the tool is now valid JSON. The PR updates the commit tag and edits the tests so that the grep matches again.

@davidchisnall
Copy link
Contributor

I would rather extract the expressions[0] field from the evaluation result than encode that in the tests and subsequently require every user to do this in their use of the output.

@matajoh
Copy link
Contributor Author

matajoh commented Jun 14, 2024

I would rather extract the expressions[0] field from the evaluation result than encode that in the tests and subsequently require every user to do this in their use of the output.

I've taken a stab at this, let me know what you think.

Signed-off-by: Matthew Johnson <[email protected]>
@davidchisnall
Copy link
Contributor

Looks like the snmalloc clone is broken?

@matajoh
Copy link
Contributor Author

matajoh commented Jun 18, 2024

I've updated it to the 0.4.0 release of Rego. The snmalloc commit issue was upstream in Trieste, and appears to be resolved for now.

@davidchisnall davidchisnall merged commit ed3a8df into CHERIoT-Platform:main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants