Add editTopo.py tool

[micaeljtoliveira]

No description provided.

[aekiss]

Is this the latest version from here? https://github.com/COSIMA/topogtools/blob/6b4983127aa18dfdf1b62b2e18b581d82d4a64d4/editTopo.py

[micaeljtoliveira]

Yes, I think so.

[aekiss]

If so, it might be good to include the commit hash or equivalently the URL https://github.com/COSIMA/topogtools/blob/6b4983127aa18dfdf1b62b2e18b581d82d4a64d4/editTopo.py in the git log to help with version control, since this script is now in 3 places and I'm not sure which of them should be thought of as definitive if we make improvements.

[micaeljtoliveira]

@aekiss Good point! I've just added the url to the commit log.

I would suggest we treat the different versions in the following way:

• the one here: used for OM3 and related models/configs.
• the one in topogtools: used for OM2 and related models/configs

The same goes for all the other tools I think. Does this sound reasonable?

[aekiss]

Yes that makes sense. It will be tricky to avoid divergence between the versions if we make changes, but it would be nice to keep them synchronised.

[micaeljtoliveira]

My thinking was that we wouldn't need to update the tools used for OM2 very often, if at all, because AFAIK, there are no planned updates to the OM2 topography.

[aekiss]

Fair point. So the version here should be though of as definitive/latest.

[aekiss]

We could put a note to that effect in the topogtools README

[micaeljtoliveira]

We could put a note to that effect in the topogtools README

Yes, I think that's a good idea.

I now realize I should have discussed this in more detail with you at some point, so that we would be on the same page. Sorry about that.

[aekiss]

no problem!

[micaeljtoliveira]

@aekiss I've now created an issue about the topogtools README.

Anything else needed here before merging this?

[aekiss]

A couple more suggestions, but other than that it's ready to merge if the only thing you changed in the code was the GPL notice at the start (ie so I don't need to check the code).

[micaeljtoliveira]

Yes, I've only added the copyright notice, everything else should be unchanged. Thanks for the review!