Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze xarray version given update causes crash #190

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Freeze xarray version given update causes crash #190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa88242
Update pyproject.toml
ashjbarnes Sep 25, 2024
66a3157
only upper bound
navidcy Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies = [
"netCDF4",
"numpy >= 1.17.0, < 2.0.0",
"scipy >= 1.2.0",
"xarray",
"xarray == 2024.7.0",
Copy link
Contributor

@navidcy navidcy Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not <=?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are older versions of xarray that also don’t work from memory. Safer to force it to one we know does work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue really? Is it documented? Or the error that one gets?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to reproduce, just run the tests like this one which used to pass before update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test you point above is from a different PR. So I'm confused @ashjbarnes. How do we know that the error in there is from the xarray version?

"xesmf >= 0.8.4",
"f90nml >= 1.4.1",
]
Expand Down
Loading