Separate initial condition and boundary #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package provides a "round-trip" mode which preserves ordering and comments.
Update with tides branch
… up the ocean forcing function
…is_from_units subroutine from complaining that it can't find x or y
…rom .toml file, update tests and demos to reflect the structural changes (ocean_forcing method replaced with separate initial condition and boundary forcing functions)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This PR also adds testing for the example notebook! Angus' docker image is now used to mount and run the package. After the normal python tests are done, pytest evaluates the |
|
how was this merged without review? |
navidcy
changed the title
OK, I just notice this. That explains it! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tidies up some code, and splits the initial conditoin and boundary forcing functions. The notebooks have been updated to reflect this change
The reason for this is more flexibility. There's no reason to re-run IC when you just want to run boundaries and vica versa