Added Richard Vogl's ADT models #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Discussion - #482
Related PR - #326
This PR adds Richard Vogl's [Vogl, 2018] Automatic Drum Transcription (ADT) models to the
madmomlibrary. (Link to directly download the .zip file: ⬇️).Other comments:
It would be extremely helpful if
madmomhad a built-in way of performing ADT. This is already marked as Work In Progress in another PR but seems to have been dropped meanwhile.I have managed to make the
DrumTranscriptorscript work locally on thedrum_transcriptorbranch by updating themodelsfolder according to this PR, and by changing the/features/drums.pyfile in my localmadmomparent repository.However, the branch itself seems to be broken (I suspect that's the reason why this has been dropped) and some of the tests when running
python setup.py pytestfail.I also tried to update the
drum_transcriptorbranch frommain, resolving conflicts as I presumed correctly (mainly choosing the changes from themainbranch), but some tests still failed (even without my changes added to the branch).Questions
drum_transcriptorbranch work, I'm not sure if I should make two separate PRs: this one, and then one on the parent repository with the changes to the/features/drums.pyfile as I have never worked with submodules before; or if I should only make one PR that encompasses all the changes, both to the submodule and the parent repository. If so, how do I do that?DrumTranscriptorscript runnable inside thedrum_transcriptorbranch, what can I do to make this branch mergeable onto themainbranch and thus incorporate ADT intomadmom? Any suggestions of what I should look for?P.S.: This is my first time contributing to an open-source library, so there are probably some things above that don't make total sense. Please bear this in mind and I apologize for some eventual lack of knowledge and know-how regarding GitHub, PRs, and how to contribute in general.
Thank you,
André C. Santos