Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
Add check in db.js of user-service to see if node_env is production env or not Use of Kubectl secrets instead of pushing .env file to docker deployment container Env variables are mentioned in the deployment.yaml
Using small letters causes production & deployment errors
endSession flow changes, popups abstracted. History service difficulty field added.
End Session flow changed.
UI timer's logic changed to reflect actual time left for session.
Race condition bug fix. usersInfo and randomQuestion can potentially be overwritten by newly matched messages.
Opponent editors remain blocked after timer ends, plus some race conditions fix.
Editing functionality on readerEditor fix on timeUp. User can edit opponents' code with expected behaviour.
Matchmaking deployment yaml files
change package.json npm start script change deployment.yaml for matchmaking-service
deployment and service yaml files for respective microservices will be held within this folder
add values.yaml to gitignore
Fix accordin title
wengkit1
had a problem deploying
to
production
GitHub Actions
Failure
change deployment.yaml for eval-service
CheongYeeMing
had a problem deploying
to
production
GitHub Actions
Failure
Update deployment.yaml
imrajsinghsandhu
had a problem deploying
to
production
GitHub Actions
Failure
History service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @CheongYeeMing @LuYiting0913 @imrajsinghsandhu