-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAM Command #4
base: master
Are you sure you want to change the base?
IAM Command #4
Conversation
please clean up that commit history. there's just waaay too many commits for one command and there should be not commits from me on there. If you don't know how to do that. I suggest making a new branch called |
@modernNeo Got it done, Jace |
|
||
public override async registerApplicationCommands(registry: ChatInputCommand.Registry) { | ||
// this.logger is a customised Winston Logger. It logs onto the console and onto Winston (file system) at the same time. | ||
this.logger = (new EveLogger('iam')).cmd_logger; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing alot of code in this function that I put into the other commands in EVE to ensure each launch of the bot results in a fresh update of al the commands, specifically ApplicationCommandRegistry
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest commit addresses this problem
src/commands/iam.ts
Outdated
|
||
// 3. Get roles, and then assign. | ||
const roles = await interaction.guild.roles.fetch(); | ||
const selected_role = roles.find(r => r.name === course); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest commit addresses this problem
const fc = interaction.options.getFocused(true); | ||
const roles = await interaction.guild.roles.fetch() | ||
const rgx = /^[a-z]/g | ||
const all_roles = Array.from(roles.values()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot to ensure that you don't return roles a user already has....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest commit addresses this problem
Something might be wrong with how the token is set up in CI. Can you look this up? |
Also, can you explain how this code block works?
|
do
to solve the CI issues |
it seems to be the only way via Sapphire to ensure the latest slash command callbacks and interaction auto-completes are fully re-synced. |
No description provided.