Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual swap from 23.11 to 24.05 #58

Closed
wants to merge 3 commits into from
Closed

Textual swap from 23.11 to 24.05 #58

wants to merge 3 commits into from

Conversation

gvnn3
Copy link
Contributor

@gvnn3 gvnn3 commented Jul 17, 2024

No description provided.

@gvnn3 gvnn3 requested review from rwatson, jrtc27 and kwitaszczyk July 17, 2024 15:41
@jrtc27
Copy link
Member

jrtc27 commented Jul 17, 2024

It's misleading to update the version number without actually updating the contents. At least when the version number is outdated people know to expect the contents to be outdated too.

@@ -61,7 +61,7 @@ You will need to reboot in order for this change to take effect.

# Heap temporal memory safety

As of CheriBSD 23.11, userlevel heap temporal safety is enabled by default with jemalloc as the memory allocator.
As of CheriBSD 24.05, userlevel heap temporal safety is enabled by default with jemalloc as the memory allocator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be less misleading to say "Since CheriBSD 23.11" for these

@@ -9,7 +9,7 @@ They have different levels of completeness, maturity, security, and support.
extends FreeBSD ports, a collection of over 34,000 third-party
software adaptations to FreeBSD, with CHERI- and CheriBSD-specific patches.
The
[releng/23.11](https://github.com/CTSRD-CHERI/cheribsd-ports/tree/releng/23.11)
[releng/24.05](https://github.com/CTSRD-CHERI/cheribsd-ports/tree/releng/23.11)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the URL too

@@ -1,6 +1,6 @@
# Userlevel heap temporal memory safety (experimental)

CheriBSD 23.11 incorporates support for userlevel heap temporal memory
As of CheriBSD 23.11 there has been support for userlevel heap temporal memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this Since to match all the others that you just changed?..

@jrtc27
Copy link
Member

jrtc27 commented Jul 17, 2024

Installation section still needs updating as the installer has definitely changed some of its dialogs, and the benchmark ABI kernel needs documenting in the kernel ABIs section. Maybe other things are outdated too, those are just the most obvious ones that spring to mind. Someone needs to own doing this properly, not just doing the easy mostly-automated part.

@brooksdavis
Copy link
Member

Rolled into #60

@gvnn3 gvnn3 deleted the gnn-24.05-versioning branch July 20, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants