Skip to content

Commit

Permalink
Merged: [compiler] check for read-only property on AccessMode::kDefine
Browse files Browse the repository at this point in the history
(cherry picked from commit 95eda07)

Change-Id: I2000f5b008a473d50a8fbb181d96668ae7b6826f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4660572
Commit-Queue: Darius Mercadier <[email protected]>
Auto-Submit: Tobias Tebbi <[email protected]>
Reviewed-by: Darius Mercadier <[email protected]>
Cr-Commit-Position: refs/branch-heads/11.5@{v8#31}
Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1}
Cr-Branched-From: b71d303-refs/heads/main@{#87781}
  • Loading branch information
tebbi authored and V8 LUCI CQ committed Jul 5, 2023
1 parent d142cbc commit a8739d5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/compiler/access-info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,7 @@ PropertyAccessInfo AccessInfoFactory::ComputePropertyAccessInfo(
}

if (index.is_found()) {
if (access_mode == AccessMode::kStore ||
access_mode == AccessMode::kStoreInLiteral) {
if (IsAnyStore(access_mode)) {
DCHECK(!map.is_dictionary_map());

// Don't bother optimizing stores to read-only properties.
Expand Down

0 comments on commit a8739d5

Please sign in to comment.