Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Navigating Dependency Chaos with Lockfiles blog post #30
Add Navigating Dependency Chaos with Lockfiles blog post #30
Changes from 10 commits
8097508
5f18c40
8f97729
799ff6b
5df963a
cd8097e
f488d47
9dcdcc8
7aadb8c
24c9323
04e96da
fff4806
3e91d8b
25652eb
36ab01a
ab5b187
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is actually broken, but I see a "broken image" icon when I view this post in the Netlify preview, just FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang, you're right, it appears the same for me. Instinct here has me thinking this might have something to do with Mermaid versions, but not sure. I'll adjust this to get it displayed correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with a dynamic reference to Mermaid 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks like that worked; it's showing up fine in the Netlify preview for me now, at least. Kudos!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed for the post but we may want to raise this with Jekyll Spaceship or elsewhere depending on what might be happening. I'm pretty sure it's a Mermaid version reference that makes this happen (mindmaps were I believe experimental or non-existent at one point). @vincerubinetti would you have any recommendations on this front?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it's worth raising an issue, though the jekyll-spaceship repo seems to have been inactive since 2022. Looking through the repo a bit, it looks like it just uses "https://mermaid.ink/svg/" as a conversion service (I think you brought this up before?). And according to that service, it has already been using Mermaid 10 for a while. Mermaid itself says that a mindmap is experimental and doesn't seem to mention which version it came to, so maybe it's extremely recent and mermaid.ink is a little behind? Either way, it seems more like an issue with mermaid.ink or mermaid itself.
Also, appropriate that you'd run into a versioning issue on this blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincerubinetti ! And agreed on the versioning issue within the context of this post 😆 - fitting ! Maybe we need a lockfile update somewhere? 🙂
I tried to create a mermaid.ink mindmap and it worked alright (link here). I'll give this a further investigation with a Jekyll-spaceship test when there's a moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've recreated the challenge outside of lab-website-template and just opened an issue on this topic here: jeffreytse/jekyll-spaceship#96