-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIG-1355: Sonchau/UUID with fk #158
Conversation
filter schema WIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this works as expected. Looks good!
5e3a172
to
4e635fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the data-portal side everything looks fine as far as I can tell, will need some modifications to data portal code to get it working with this but nothing too out-of-the-ordinary ✔️ .
What's new:
submitter__ids will be stored in each object as a text field.
Potentially Breaking changes:
program_id
andsubmitter_*_id
."/v2/authorized/donor_with_clinical_data/program/{program_id}/donor/{donor_id}"
python chord_metadata_service/mohpackets/data/data_loader.py
Package changes:
How to test:
pip install -r requirements/local.txt
tox
Related tickets:
DIG-1389
DIG-1312