Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass in OPA_SECRET #208

Merged
merged 2 commits into from
May 28, 2024
Merged

Don't pass in OPA_SECRET #208

merged 2 commits into from
May 28, 2024

Conversation

daisieh
Copy link
Member

@daisieh daisieh commented May 27, 2024

Latest Opa and authx don't require the OPA_SECRET anymore.

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.72%. Comparing base (4e936a8) to head (81dc7e7).

Files Patch % Lines
chord_metadata_service/mohpackets/apis/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
+ Coverage    96.69%   96.72%   +0.02%     
===========================================
  Files           35       35              
  Lines         3570     3569       -1     
===========================================
  Hits          3452     3452              
+ Misses         118      117       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daisieh daisieh requested a review from kcranston May 27, 2024 19:38
@daisieh daisieh merged commit fc37fe9 into develop May 28, 2024
6 checks passed
@daisieh daisieh deleted the daisieh/no-service-token branch May 28, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants