Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-1834: modify factories and data so ALL complete #275

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mshadbolt
Copy link

  • Tweaked thing in the AllSynth factories to ensure no required or conditional fields are null
  • regenerated jsons for all sized datasets

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (ac1b6de) to head (88025b7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #275   +/-   ##
========================================
  Coverage    93.64%   93.64%           
========================================
  Files           35       35           
  Lines         2581     2581           
========================================
  Hits          2417     2417           
  Misses         164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mshadbolt
Copy link
Author

I am hesitant to merge this because it will update synthetic data which will affect playwright tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant