Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unlisted videos limitations #308

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

wdestin
Copy link
Contributor

@wdestin wdestin commented Mar 15, 2021

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, I think we need to update

def action_add(user_id, video = %Video{}) do
as well, otherwise we will never record any unlisted_video.

Adding a test is also a good way to make sure that it works. That can either be done in apps/cf/test/accounts/user_permissions_test.exs or apps/cf/test/videos/videos_test.exs

@wdestin wdestin force-pushed the 152-lower-reputation-required-for-unlisted-video branch from 910d40a to 3bb3b42 Compare April 2, 2021 16:05
@wdestin wdestin requested a review from Betree April 2, 2021 16:16
@wdestin
Copy link
Contributor Author

wdestin commented Jun 6, 2021

@Betree This one needs your review too.

@Betree Betree force-pushed the staging branch 6 times, most recently from 8edadfd to a2007b8 Compare May 3, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower reputation to add unlisted video / baisser la réputation requise pour ajouter des vidéos non listées
2 participants