[ENG-6821] Fix CrossRef DOI check task #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore providers that are not configured * Improve exception handling and add sentry logging
cslzchen
force-pushed
the
feature/fix-crossref-doi-check
branch
from
dd5ffd2 to
0a46e0e
Compare
cslzchen
commented
Jan 3, 2025
Comment on lines
+69
to
+73
| if not doi_prefix: | ||
| sentry.log_message(f'Preprint [_id={preprint._id}] has been skipped for CrossRef DOI Check ' | ||
| f'since the provider [_id={preprint.provider._id}] has invalid DOI Prefix ' | ||
| f'[doi_prefix={doi_prefix}]') | ||
| continue |
There was a problem hiding this comment.
For reviewer: Ignore provider that is not properly configured for CrossRef.
Comment on lines
+82
to
+83
| sentry.log_message(f'Could not contact crossref to check for DOIs, response returned with exception {exc}') | ||
| continue |
There was a problem hiding this comment.
For reviewer: don't quit if one batch failed. Log to sentry and continue.
Comment on lines
+90
to
+92
| if not base_guid or not version: | ||
| sentry.log_message(f'[Skipped] Preprint [_id={preprint__id}] returned by CrossRef API has invalid _id') | ||
| continue |
There was a problem hiding this comment.
For reviewer: CrossRef must return the correct full (base and version) _id. Similarly, don't quit but just skip if one fails.
Comment on lines
+96
to
+99
| ).first() | ||
| if not pending_preprint: | ||
| sentry.log_message(f'[Skipped] Preprint [_id={preprint__id}] returned by CrossRef API is not found.') | ||
| continue |
There was a problem hiding this comment.
For reviewer: use filter() and added None check. Similarly, don't quit but just skip if one fails.
brianjgeiger
approved these changes
Jan 3, 2025
|
No new failures and merging now. |
cslzchen
merged commit 45af5db
into
CenterForOpenScience:feature/preprints-doi-versioning
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CrossRef DOI check task
Changes
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-6821