Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP: Support gallery Shortcode #23

Closed
GreenCappuccino opened this issue Oct 4, 2021 · 2 comments · Fixed by #28
Closed

MVP: Support gallery Shortcode #23

GreenCappuccino opened this issue Oct 4, 2021 · 2 comments · Fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@GreenCappuccino
Copy link
Contributor

The current gallery section generator only supports generation from ngg shortcodes. gallery shortcodes are also used on the site. Support them.

image
It seems that this form of gallery uses regular WordPress media IDs, so it should be relatively simple to implement with the WordpressMediaService.

@GreenCappuccino GreenCappuccino added the bug Something isn't working label Oct 4, 2021
@GreenCappuccino GreenCappuccino self-assigned this Oct 4, 2021
@GreenCappuccino GreenCappuccino changed the title Support gallery Shortcode MVP: Support gallery Shortcode Oct 4, 2021
@GreenCappuccino
Copy link
Contributor Author

Currently an implementation requires making N requests, one for each image to load... Creating a new API endpoint for gallery data seems ideal.

So this issue is currently blocked by CentralTimes/wp_centraltimes#1 .

@GreenCappuccino
Copy link
Contributor Author

Unblocked as CentralTimes/wp_centraltimes#1 is resolved per CentralTimes/wp_centraltimes#2 .

@GreenCappuccino GreenCappuccino linked a pull request Oct 10, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant