implement SNO gallery #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreenCappuccino
commented
Oct 10, 2021
| @@ -25,10 +24,9 @@ class PostsPageState extends State<PostsPage> with TickerProviderStateMixin { | |||
| Tab(child: Text("All")), | |||
| ...tabCategories.map((e) => Tab(child: Text(e.name))).toList() | |||
| ]), | |||
| child: Flexible( | |||
| child: TabBarView(controller: tabController, children: [ | |||
| child: TabBarView(controller: tabController, children: [ | |||
There was a problem hiding this comment.
Small fix to prevent exception from occurring related to Flexible
GreenCappuccino
commented
Oct 10, 2021
| @@ -16,7 +17,7 @@ import 'package:wordpress_api/wordpress_api.dart'; | |||
| void main() async { | |||
| Logger.root.level = Level.INFO; | |||
| Logger.root.onRecord.listen((record) { | |||
| print( | |||
| debugPrint( | |||
There was a problem hiding this comment.
debugPrint will not attempt to print on production builds, as opposed to print
|
@daniel-n6 I recommend taking a quick look at this and pulling changes before continuing work on #18 . |
dwu359
approved these changes
Oct 11, 2021
|
Yep, as I understand you're working on #18 ? This actually uses the same code to render the gallery as for NextGEN galleries... so resolving that will do so for both types of galleries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #23
galleryshortcode is now implemented on same section asngg!However, this implementation does not fetch author names.... something that has to be implemented later, and is blocked by the API.