Allow implicit subtree buffers to be padded to 8 bytes. #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kring
commented
Jan 16, 2024
Comment on lines
+225
to
+230
| // tell client to retry later | ||
| return TileLoadResult::createRetryLaterResult(nullptr); | ||
| } else { | ||
| // Subtree load failed, so this tile fails, too. | ||
| return TileLoadResult::createFailedResult(nullptr); | ||
| } |
There was a problem hiding this comment.
This change (and the similar one below) ensures that invalid subtrees are not loaded repeatedly, spamming an error to the log each time.
|
Thanks @kring ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the 3D Tiles spec says that binary implicit tiling subtrees should have a binary buffer that is padded to 8 bytes. But cesium-native was only expecting 4-byte alignment, and considering the subtree to be invalid if it was too large. To make matters worse, the "buffer is not the expected size" error was lost and not displayed to the user. This PR fixes both problems.
As reported here:
https://community.cesium.com/t/re-catching-up-cesium-scaled-foundations/29226