Allow token-less tilesets to load #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check for an empty token when configuring a tileset.
This check was preventing some tilesets from loading in scenarios such as using Cesium ion Self-Hosted in developer mode, which does not use Oauth, and a token is not provided. #702
I'm not 100% sure if there was anything more to the original if statement other than being a sanity check that all values were valid, but @lilleyse please let me know if there is something more to it and we'll work out another approach if needed.
I've tested this with both Self-Hosted and ion content and it appears to be working fine.