Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #736

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Fix CI #736

merged 9 commits into from
Oct 1, 2024

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Oct 1, 2024 •
edited
Loading

CI was broken with the most recent update to ubuntu-latest.

  • Removed step that was uninstalling system libs. Some of these don't exist anymore and was causing the build to fail. Turns out we don't actually need this step anymore and apparently have enough space.
  • Removed CUDA. I'm not sure if this was breaking the build, but we don't need CUDA unless we revisit Add foundational CUDA support and basic kernel #459
  • Switched to GCC 13. GCC 11 is no longer available on ubuntu-latest
  • The 6.0.0 version of flake8 was causing issues suddenly. Switched to 7.1.1 and all is good now.

corybarr
corybarr approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@corybarr corybarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 1, 2024

Can't seem to access https://ftpmirror.gnu.org/gnu/m4/m4-1.4.19.tar.xz right now. Will try restarting the build tomorrow.

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 1, 2024

Still waiting for the network issue to resolve, but I'm going to merge this to start the release process.

@lilleyse lilleyse merged commit c8daba3 into main Oct 1, 2024
2 of 6 checks passed
@lilleyse lilleyse deleted the fix-ci branch October 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corybarr corybarr corybarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilleyse @corybarr