Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AEC design sandcastle examples #12326

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Add AEC design sandcastle examples #12326

merged 5 commits into from
Nov 25, 2024

Conversation

r-veenstra
Copy link
Contributor

Description

Implements three new Architecture, Engineering and Construction (AEC) related Sandcastle examples to support upcoming Cesium releases.

AEC Architectural Design.html demonstrates a typical architectural design model comprised of multiple tilesets with layer visibility toggles and metadata picking.

AEC Isolate by Category demonstrates how to use architectural categories embedded within the tileset metadata to isolate building elements such as doors, floors, stairs, etc.

AEC Metadata Styling.html demonstrates how to interactively style pipeing layers, highlighting pipes whose length falls within a min / max range controller by a UI widget.

Issue number and link

N/A

Testing plan

  1. Review each sandcastle example
  2. Ensure tilesets load appropriately
  3. Ensure UI elements and any interactive functionality are working
  4. Make sure the title, description and thumbnail are correct

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Nov 22, 2024

Thank you for the pull request, @r-veenstra! Welcome to the Cesium community!

In order for us to review your PR, please complete the following steps:

Review Pull Request Guidelines to make sure your PR gets accepted quickly.

@ggetz
Copy link
Contributor

ggetz commented Nov 22, 2024

Thanks @r-veenstra! I can confirm we have a CLA on file for you.

We'll review these shortly!

@ggetz
Copy link
Contributor

ggetz commented Nov 22, 2024

@r-veenstra These examples are looking great! Is there any reason this PR is still in "Draft" as opposed to "Ready for Review"?

@r-veenstra
Copy link
Contributor Author

@ggetz I just need to update the tilesets with some new ion asset ids, which I expect to do over the weekend. Once that's done, I'll move the PR to ready for review.

@r-veenstra r-veenstra marked this pull request as ready for review November 25, 2024 05:36
@r-veenstra
Copy link
Contributor Author

@ggetz this should be ready to go

@ggetz
Copy link
Contributor

ggetz commented Nov 25, 2024

These all look great. Thanks @r-veenstra!

@ggetz ggetz added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit cb9fbec Nov 25, 2024
5 checks passed
@ggetz ggetz deleted the aec-design-sandcastle branch November 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants