Add Taproot descriptors #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichai
force-pushed
the
2019-07-tap-desc
branch
from
9f98729 to
520e600
Compare
elichai
changed the base branch from
taproot-merge-8f60436
to
taproot-rebase-52b9797
|
Sipa has updated the taproot branch based on your rebase. Do you want to rebase this PR on the taproot branch here: https://github.com/ChaincodeResidency/bitcoin/tree/taproot ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is part of the code i've been working on as part of the residency,
Adding output descriptors to sipa's taproot branch.
Still missing some more unit tests and a bunch of functional tests (thinking of writing some descriptor generator for the tests)
Any kind of review is more than welcome as this PR can't be opened directly to core anytime soon (at the very least taproot should be merged if not even activated)
In general the descriptors look something like this:
tap(INTERNAL_KEY, {pk(KEY1),{{pk(KEY3),pk(KEY3)},pkh(KEY2)}})Concrete example:
P.S. Currently this does not support signing as adding signing support now will require a lot of changes to wallet format(saving merkle paths etc.) which will be way way easier with bitcoin#16528 (native descriptors) so i'll wait for that to get merged.