Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python multipart to 0.0.18 #1563

Closed
wants to merge 1 commit into from
Closed

Conversation

tituslhy
Copy link

@tituslhy tituslhy commented Dec 3, 2024

Bumping multipart dependency to resolve feature request #1561

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. backend Pertains to the Python backend. labels Dec 3, 2024
@dokterbob
Copy link
Collaborator

Why this consistently fails is beyond me...

Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib but... this updates a lot more than just python-multipart!

Potentially causing a lot of side-effects (maybe that's why tests are failing). A patch updating python-multipart should really just be updating that.

In the end I did poetry add 'python-multipart>=0.0.18,<0.1', to keep with my suggested ^0.0 but also require >0.0.18 as there's a security issue (https://github.com/Chainlit/chainlit/security/dependabot/99).

To save both of us a bit of time, I already created the PR. #1570

Love to hear your feedback though, does it solve your issue?

@dokterbob
Copy link
Collaborator

Superseded by #1570

@dokterbob dokterbob closed this Dec 5, 2024
@tituslhy
Copy link
Author

tituslhy commented Dec 6, 2024

Yes it does solve my issue - I use LlamaIndex heavily for orchestration and Chainlit for frontend!

The failing tests are weird. I only updated the pyproject.toml file and later just ran poetry lock and checked in both the pyproject.toml and poetry.lock file. I think the locking process caused Python to automatically update the rest of the dependencies which caused the tests to fail.

Thanks @dokterbob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Pertains to the Python backend. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Python Multipart dependency
2 participants