Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add voice audio preview button in tts-config option 为 TTS 设置选项添加了语音预览按钮 #5651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add voice audio preview button in tts-config option 为 TTS 设置选项添加了语音预览按钮 #5651

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcd50b8
feat: add voice audio preview button in tts-config option
Dakai Oct 13, 2024
67192a7
follow the rabbit to fix potential issues
Dakai Oct 13, 2024
ab4bf3b
remove redundancy code
Dakai Oct 16, 2024
c3b50a9
refactor: optimize playSpeech function in TTSConfigList component
Dakai Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 74 additions & 16 deletions app/components/tts-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,59 @@
import { TTSConfig, TTSConfigValidator } from "../store";
import React, { useState } from "react";

import Locale from "../locales";
import { ListItem, Select } from "./ui-lib";
import {
ModelProvider,
DEFAULT_TTS_ENGINE,
DEFAULT_TTS_ENGINES,
DEFAULT_TTS_MODELS,
DEFAULT_TTS_VOICES,
} from "../constant";
import { InputRange } from "./input-range";
import { IconButton } from "./button";
import SpeakIcon from "../icons/speak.svg";
import SpeakStopIcon from "../icons/speak-stop.svg";
import { createTTSPlayer } from "../utils/audio";
import { useAppConfig } from "../store";
import { ClientApi } from "../client/api";

const ttsPlayer = createTTSPlayer();
export function TTSConfigList(props: {
ttsConfig: TTSConfig;
updateConfig: (updater: (config: TTSConfig) => void) => void;
}) {
const [speechLoading, setSpeechLoading] = useState(false);
const [speechStatus, setSpeechStatus] = useState(false);

async function openaiSpeech(text: string) {
if (speechStatus) {
ttsPlayer.stop();
setSpeechStatus(false);
} else {
const api = new ClientApi(ModelProvider.GPT);
const config = useAppConfig.getState();
setSpeechLoading(true);
ttsPlayer.init();
let audioBuffer: ArrayBuffer;
audioBuffer = await api.llm.speech({
model: config.ttsConfig.model,
input: text,
voice: config.ttsConfig.voice,
speed: config.ttsConfig.speed,
});
setSpeechStatus(true);
ttsPlayer
.play(audioBuffer, () => {
setSpeechStatus(false);
})
.catch((e) => {
console.error("[OpenAI Speech]", e);
setSpeechStatus(false);
})
.finally(() => setSpeechLoading(false));
}
}
Dakai marked this conversation as resolved.
Show resolved Hide resolved
return (
<>
<ListItem
Expand Down Expand Up @@ -88,23 +128,41 @@ export function TTSConfigList(props: {
title={Locale.Settings.TTS.Voice.Title}
subTitle={Locale.Settings.TTS.Voice.SubTitle}
>
<Select
value={props.ttsConfig.voice}
onChange={(e) => {
props.updateConfig(
(config) =>
(config.voice = TTSConfigValidator.voice(
<div style={{ display: "flex", gap: "10px" }}>
<IconButton
aria={Locale.Chat.Actions.Speech}
icon={speechStatus ? <SpeakStopIcon /> : <SpeakIcon />}
text={
speechLoading
? "Loading..."
: speechStatus
? Locale.Chat.Actions.Stop
: Locale.Chat.Actions.Speech
}
onClick={() => {
openaiSpeech(
"NextChat,Unleash your imagination, experience the future of AI conversation.",
);
}}
/>

<Select
value={props.ttsConfig.voice}
onChange={(e) => {
props.updateConfig((config) => {
config.voice = TTSConfigValidator.voice(
e.currentTarget.value,
)),
);
}}
>
{DEFAULT_TTS_VOICES.map((v, i) => (
<option value={v} key={i}>
{v}
</option>
))}
</Select>
);
});
}}
>
{DEFAULT_TTS_VOICES.map((v, i) => (
<option value={v} key={i}>
{v}
</option>
))}
</Select>
</div>
Comment on lines +148 to +182
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Several UI improvements recommended.

  1. The preview text should be localized
  2. Consider moving inline styles to CSS classes
  3. The loading state could benefit from a loading spinner component
-<div style={{ display: "flex", gap: "10px" }}>
+<div className="tts-voice-controls">

-text={
-  speechLoading
-    ? "Loading..."
-    : speechStatus
-    ? Locale.Chat.Actions.Stop
-    : Locale.Chat.Actions.Speech
-}
+text={
+  speechLoading
+    ? Locale.Chat.Actions.Loading
+    : speechStatus
+    ? Locale.Chat.Actions.Stop
+    : Locale.Chat.Actions.Speech
+}

-"NextChat,Unleash your imagination, experience the future of AI conversation."
+Locale.Settings.TTS.PreviewText

Add this CSS to your stylesheet:

.tts-voice-controls {
  display: flex;
  gap: 10px;
  align-items: center;
}

</ListItem>
<ListItem
title={Locale.Settings.TTS.Speed.Title}
Expand Down