Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 1 to start and end line for filesystem cases #243

Merged
merged 5 commits into from
May 28, 2024
Merged

feat: add 1 to start and end line for filesystem cases #243

merged 5 commits into from
May 28, 2024

Conversation

cx-ruio
Copy link
Collaborator

@cx-ruio cx-ruio commented May 23, 2024

Similarly to gitleaks (whose change was added in version 8.1.3), it is necessary to increment the start and end line for filesystem cases.

Checklist

  • I covered my changes with tests.
  • I Updated the documentation that is affected by my changes:
    • Change in the CLI arguments
    • Change in the configuration file

@cx-ruio cx-ruio requested review from diogo-fjrocha May 27, 2024 09:12
@cx-ruio cx-ruio changed the title Add 1 to start and end line for filesystem cases feat: add 1 to start and end line for filesystem cases May 27, 2024
@github-actions GitHub Actions
Copy link

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 9
Files parsed placeholder 9
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 98a387b8-75d9-4fd1-923d-4c7e6728a0fb

No New Or Fixed Issues Found

@cx-ruio cx-ruio added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 05dc8d7 May 28, 2024
11 checks passed
@cx-ruio cx-ruio deleted the AST-43662-backend-change-line-number-in-2-ms branch May 28, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogo-fjrocha diogo-fjrocha diogo-fjrocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cx-ruio @diogo-fjrocha