Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built assets from git #688

Closed
wants to merge 5 commits into from
Closed

Conversation

jshjohnson
Copy link
Collaborator

No description provided.

@jshjohnson
Copy link
Collaborator Author

@tinovyatkin I can't find your comment regarding having the npm deploy script run as a github action. Is this technically possible?

It would need to:

  • Only deploy after a successful npm publish
  • Build assets
  • Push the contents of the public folder to the gh-pages branch (including all built assets)

The inclusion of the built assets is the tricky bit 🤔

@jshjohnson
Copy link
Collaborator Author

This is what I based the current setup on: https://gist.github.com/cobyism/4730490

@tinovyatkin
Copy link
Contributor

tinovyatkin commented Oct 24, 2019

@tinovyatkin I can't find your comment regarding having the npm deploy script run as a github action. Is this technically possible?

The original comment is here: #669 (comment)

Yes, it's possible to run npm deploy from GitHub Action, but if you are doing git push from that action then you need to specify full repository URL with authentication parameters, as in my comment, or, override repository origin to that URL before doing push.
GitHub is making things easier regarding git push from Actions, but it's not released yet.

@jshjohnson jshjohnson closed this Oct 24, 2019
@jshjohnson jshjohnson deleted the remove-built-assets-from-git branch October 24, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants